If you haven’t given much thought to what makes a great Git commit message, it may be the case that you haven’t spent much time using git log and related tools. Commit messages can do exactly that and as a result, a commit message shows whether a developer is a good collaborator. We can’t avoid it completely, so our efforts should go to reducing it as possible. Peter Hutterer makes this point well: Re-establishing the context of a piece of code is wasteful. A diff will tell you what changed, but only the commit message can properly tell you why. The contributors to these repositories know that a well-crafted Git commit message is the best way to communicate context about a change to fellow developers (and indeed to their future selves). Look at Spring Boot, or any repository managed by Tim Pope. The Linux kernel and Git itself are great examples. While many repositories’ logs look like the former, there are exceptions. The former is what happens by default the latter never happens by accident. The former varies in length and form the latter is concise and consistent.
Bitcoin core github update#
Compare that with these more recent commits from the same repository: $ git log -oneline -5 -author pwebb -before "Sat Aug 30 2014"ĥba3db6 Fix failing CompositePropertySourceTestsĮ142fd1 Add tests for ImportSelector meta-dataĨ87815f Update docbook dependency and generate epub
Bitcoin core github manual#
The test method is still useful, but should only be run on a manual basis to ensure CGLIB is not prematurely classloaded, and should not be run as part of the automated build.Ģdb0f12 fixed two build-breaking issues: + reverted ClassMetadataReadingVisitor to revision 794 + eliminated ConfigurationPostProcessorTests until further investigation determines why it causes downstream tests to fail (such as the seemingly unrelated ClassPathXmlApplicationContextTests)ġ47709f Tweaks to package-info.java filesĢ2b25e0 Consolidated Util and MutableAnnotationUtils classes into existing AsmUtils
The classloader hacking causes subtle downstream effects, breaking unrelated tests. the testCglibClassesAreLoadedJustInTimeForEnhancement() method as it turns out this was one of the culprits in the recent build breakage. For example, take a look at these gems from my early days committing to Spring: $ git log -oneline -5 -author cbeams -before "Fri Mar 26 2009"Į5f4b49 Re-adding ConfigurationPostProcessorTests after its brief removal in r814. If you browse the log of any random Git repository, you will probably find its commit messages are more or less a mess. Contents: Introduction | The Seven Rules | Tips Introduction: Why good commit messages matter
0 kommentar(er)
